Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract hls-test-utils #1606

Merged
merged 6 commits into from Mar 23, 2021
Merged

Conversation

berberman
Copy link
Collaborator

With the migration of plugins' tests from HLS's func-test to their own packages, the common stanza hls-test-utils will no loger be available in the pattern that tests of plugins were imported as sources into func-test. But there are still many common functions need to be shared. Therefore, this PR extracts Test.Hls.Util into a new package hls-test-utils, with some re-exported modules. Plugin test executables now can depend on this new package, rather than data-default, lsp-test, tasty-*, etc.

Moreover, this PR finishes the migration of eval plugin tests.

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look really great, this was a necessary step, many thanks
we will have another package to maintain in hackage but I hope it will not change frequently (maybe if re-exported packages change?)

@jneira
Copy link
Member

jneira commented Mar 22, 2021

eval tests are failing in windows with Exception: Timed out waiting to receive a message from the server.
rerunning just if case (but i dont have many hopes)

@jneira
Copy link
Member

jneira commented Mar 22, 2021

I've tried the hls-eval-plugin test suite locally with no luck: 40 out of 50 tests failed (2379.28s)
Lots of timeouts, but

  Multi line comments, with the last test line ends without newline:                                  FAIL (7.11s)
    test\Main.hs:186:
    expected: "module TEndingMulti where\n\n-- Now trailing doctest is allowed:\n\n{- >>> 42\n>>> 54\n42\n54\n-}\n"
     but got: "module TEndingMulti where\n\n-- Now trailing doctest is allowed:\n\n{- >>> 42\n>>> 54\n<stderr>: hPutChar: invalid argument (invalid character)\n-}\n"
  Evaluate expressions in Plain comments in both single line and multi line format:                   FAIL
    Exception: Timed out waiting to receive a message from the server.
    Last message received:
    {
        "id": 2,
        "jsonrpc": "2.0",
        "error": {
            "message": "C:\\TEMP\\TPl7BFB.hs: hPutChar: invalid argument (invalid character)",
            "code": -32603
        }
    }

@berberman berberman merged commit 7255b40 into haskell:master Mar 23, 2021
@berberman berberman deleted the test-utils-package branch March 23, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants