Wingman: New AbstractLSP interface #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneira
approved these changes
Aug 13, 2021
Yeah, probably, but I want to play with it for a while to make sure there are no glaring problems. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
Interactiontype, which bundles up all of the repeated machinery necessary to implement commands/handlers. It provides the same API to code lenses and actions, and abstracts away a lot of the pain of dealing with LSP directly.I've ported Wingman's code actions over to this new system. This is purely a refactoring, but cleans up a lot of the technical debt I'd been accumulating.