This repository has been archived by the owner on Feb 3, 2022. It is now read-only.
Fix GhcDist.hs Shake dependency #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GhcDist.hs aborts with an error message when Shake 0.15 is used. We therefore tell Cabal to depend on "shake < 0.15". This change closes #173.
|
Note that in the near future, I'll fix the code to work with newer Shake |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change being pushed addresses issue #173 by requiring a version of Shake preceding the changes that break haskell-platform. In order to test that with Travis CI, though, I also had to pull in 9265be2 from the
pre-releasebranch and edit the.travis.ymlfile to state that the build setup (specifically,travis-setup.sh) needs to runsudo. The result works formasterbut introduces some new dependency-related problems when I tried it withpre-release.