Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.guess, config.sub to their latest versions #579

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

sevanspowell
Copy link
Contributor

  • Allows the new GHC Javascript backend to build network.

It is still not easy to build network with the new GHC Javascript backend, you must vendor the package and run autoreconf -i before build (as shown in haskell/cabal#4903 (comment)).

- Primarily to allow the new GHC Javascript backend to build network.
@kazu-yamamoto
Copy link
Collaborator

We stick to autoconf v2.69 because of #502 and #508.

@sevanspowell Which version of autoconf are you using?

@Mistuke Does autoconf v2.72 solve Window's problem?

@sevanspowell
Copy link
Contributor Author

I think I can minimize the diff, I likely don't need to change config.guess, and only need a few lines related to GHCJS/Javascript from config.sub.

@sevanspowell
Copy link
Contributor Author

sevanspowell commented Jun 10, 2024

Which version of autoconf are you using?

2.71, but I pulled these files direct from https://git.savannah.gnu.org/cgit/config.git/plain/config.sub?id=948ae97ca5703224bd3eada06b7a69f40dd15a02.

@sevanspowell
Copy link
Contributor Author

I'll try and include a script to reproduce the issue (likely with docker) in the next couple of days.

@sevanspowell
Copy link
Contributor Author

Although @kazu-yamamoto, it looks like CI passed (mostly, macOS-latest 8.4 might need a retry), would you expect the linked issues to be reflected in the status of the CI?

@kazu-yamamoto
Copy link
Collaborator

According to #501, if network can be built on CI, that change is acceptable.
But I'm waiting for @Mistuke's confirmation.

P.S.

I can build network with configure generated by autoconf 2.72 and this PR on Windows.

@Mistuke
Copy link
Collaborator

Mistuke commented Jun 11, 2024 via email

@kazu-yamamoto kazu-yamamoto merged commit e8310db into haskell:master Jun 11, 2024
13 of 14 checks passed
@kazu-yamamoto
Copy link
Collaborator

Merged.
Thank you all guys!

@sevanspowell Would you tell me what you want to do next.

@sevanspowell
Copy link
Contributor Author

sevanspowell commented Jun 12, 2024

Thanks @kazu-yamamoto, I hope this proves helpful to those building with the new GHC Javascript backend.

I don't think I need you to do anything next. We'd need to release a new version of network at some point, but there is no rush (if there's anything I can do to help, let me know).

There are some lingering "issues" with building network with the GHC JS backend, but I wouldn't call them issues so much as inconveniences. I'm used to adding a package to my cabal file and thinking no more about it. But with network I have to vendor the package (cabal unpack), add it to optional-packages in my cabal.project, run autoreconf -i in the vendored package folder, then cabal build my project. It doesn't seem like there's a simple way to overcome that, but I could be wrong.

Personally I have used haskell.nix to work around this inconvenience successfully (see https://github.com/sambnt/haskell-js-templates/blob/master/templates/04-oauth/nix/hix.nix#L30), but I worry about those not using haskell.nix.

There are additionally some issues with haskell.nix trying to include files from extra-source-files which don't exist (configure for example) https://github.com/haskell/network/blob/master/network.cabal#L59. But I believe that's a haskell.nix issue.

@kazu-yamamoto
Copy link
Collaborator

I will release the next version with configure generated by configure v2.72.
If this version cannot be built for some Windows users, I will fall back to the old configure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants