Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing the unnecessary withMVar (#327). #330

Merged
merged 1 commit into from
Jun 25, 2018
Merged

removing the unnecessary withMVar (#327). #330

merged 1 commit into from
Jun 25, 2018

Conversation

kazu-yamamoto
Copy link
Collaborator

This should fix #327.

@kazu-yamamoto
removing the unnecessary withMVar (haskell#327).
4fb5340 
mkWeakMVar is not used anymore. So, this code is not necessary.
eborden
eborden approved these changes Jun 25, 2018
View reviewed changes
Copy link
Collaborator

@eborden eborden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We also need to port this over to 2.6.x.x, since that is the version that #327 is targeting.

@eborden eborden merged commit ff2d0ec into haskell:2.7 Jun 25, 2018
@eborden
Copy link
Collaborator

eborden commented Jun 25, 2018 •
edited
Loading

I cherry picked this over to 2.6

@eborden
Copy link
Collaborator

eborden commented Jun 25, 2018

6ee1901

@kazu-yamamoto kazu-yamamoto deleted the revert-withmvar branch June 26, 2018 00:58
This was referenced Jul 7, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eborden eborden eborden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kazu-yamamoto @eborden