Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add support for QuickCheck 2.9.x #138

Closed
peti opened this issue Oct 1, 2016 · 7 comments · Fixed by #153
Closed

Please add support for QuickCheck 2.9.x #138

peti opened this issue Oct 1, 2016 · 7 comments · Fixed by #153

Comments

@peti
Copy link

peti commented Oct 1, 2016

The test suite constrains QuickCheck ==2.7.*, but that restrictions seems unnecessary, i.e. the build works fine if that version range is extended to incude 2.8.* (and possibly 2.9.x as well, though I didn't test that).

@hvr
Copy link
Member

hvr commented Oct 1, 2016

@peti not sure what you mean, current Git master allows only QuickCheck==2.9.* since
31edb3f

@peti
Copy link
Author

peti commented Oct 1, 2016

Well, cabal install vector doesn't use the git repository, unfortunately. The restriction seems to be still in place on the latest Hackage release.

@hvr
Copy link
Member

hvr commented Oct 1, 2016

I see; well for the released version QuickCheck 2.9 wouldn't work due to some orphan instance collision. So at best the upper bound could be relaxed allow 2.8.*. Just wondering, what benefit does it have for you if the testsuite is able to use a newer QC version?

@peti
Copy link
Author

peti commented Oct 1, 2016 via email

@peti
Copy link
Author

peti commented Feb 12, 2017

In LTS 8.x, which has QuickCheck version 2.9.2, the test suite no longer compiles at all.

@peti peti changed the title Please relax version constraint on QuickCheck to allow for modern versions Please add support for QuickCheck 2.9.x Feb 12, 2017
@RyanGlScott
Copy link
Member

For the sake of being explicit, here is the error that I think @peti is alluding to:

rgscott@gearloose:~/.../Hacking/Haskell/vector-0.12.0.0$ cabal build
Building vector-0.12.0.0...
Preprocessing library vector-0.12.0.0...
Preprocessing test suite 'vector-tests-O0' for vector-0.12.0.0...
[6 of 6] Compiling Main             ( tests/Main.hs, dist/build/vector-tests-O0/vector-tests-O0-tmp/Main.o )

tests/Main.hs:4:1: error:
    Failed to load interface for ‘Tests.Vector.UnitTests’
    Use -v to see a list of the files searched for.

This should an easy fix. I'll work on it.

@RyanGlScott
Copy link
Member

This has been fixed upstream. Now we just need to upload a new minor release to get the tests back on nixpkgs/Stackage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants