Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include modules that test-suites depend on in other-modules #153

Merged
merged 1 commit into from
Feb 25, 2017
Merged

Include modules that test-suites depend on in other-modules #153

merged 1 commit into from
Feb 25, 2017

Conversation

RyanGlScott
Copy link
Member

As noted in #138 (comment), vector's test suites do not compile when obtained from Hackage. That is because a module that the test suites depend on (Tests.Vector.UnitTests) is not included with the tarball that gets uploaded to Hackage, so when one attempts to compile the test suites from Hackage, you get a "Failed to load interface" error.

This fixes the issue by adding Tests.Vector.UnitTests (and other dependent modules) to an other-modules stanza in the test suites, which makes Cabal include them in a release tarball. As a result, there's no need to list them explicitly in extra-source-files anymore.

Since this issue is keeping vector partially blocked from Stackage, it'd probably be a good idea to make a minor release with this change.

Fixes #138.

@RyanGlScott RyanGlScott merged commit f765c83 into haskell:master Feb 25, 2017
@cartazio
Copy link
Contributor

cartazio commented Feb 25, 2017 via email

@cartazio
Copy link
Contributor

@RyanGlScott it looks like @hvr and @dolio are the two folks who are active that have uploader permissions (bos and romanL of ancient times )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add support for QuickCheck 2.9.x
2 participants