Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pgcrypto extension creation failures on heroku (fix #495) #496

Merged
merged 1 commit into from
Sep 20, 2018
Merged

fix pgcrypto extension creation failures on heroku (fix #495) #496

merged 1 commit into from
Sep 20, 2018

Conversation

ecthiender
Copy link
Member

@ecthiender ecthiender commented Sep 20, 2018 •
edited
Loading

Description

Fixes #495

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content

Related Issue

#495

Solution and Design

Create the extension explicitly mentioning the public schema.

Tests

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.

@shahidhk shahidhk closed this Sep 20, 2018
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-496.herokuapp.com is deleted

@shahidhk shahidhk reopened this Sep 20, 2018
@shahidhk
Copy link
Member

@ecthiender What about hdb_catalog? Event triggers need the extension to generate event ids.

@shahidhk shahidhk added the c/server Related to server label Sep 20, 2018
@ecthiender
Copy link
Member Author

Event triggers use the function from public schema.

@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-496.herokuapp.com

@shahidhk shahidhk changed the title fix creating pgcrypto extension fails on heroku (fix #495) fix pgcrypto extension creationg failures on heroku (fix #495) Sep 20, 2018
@shahidhk shahidhk changed the title fix pgcrypto extension creationg failures on heroku (fix #495) fix pgcrypto extension creation failures on heroku (fix #495) Sep 20, 2018
@shahidhk shahidhk merged commit 04696ae into hasura:master Sep 20, 2018
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-496.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Feb 14, 2021
@rakeshkky @0x777
@eviefp @hasura-bot
server: generalize schema cache building (#496)
9ef6033 
Co-authored-by: Vamshi Surabhi <vamshi@hasura.io>
Co-authored-by: Vladimir Ciobanu <admin@cvlad.info>
Co-authored-by: Antoine Leblanc <antoine@hasura.io>
Co-authored-by: Stylish Haskell Bot <stylish-haskell@users.noreply.github.com>
GitOrigin-RevId: 9d63187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x777 0x777 0x777 approved these changes

Assignees
No one assigned
Labels
c/server Related to server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

creating pgcrypto extension fails on existing databases on heroku
4 participants
@ecthiender @hasura-bot @shahidhk @0x777