server: metadata separation: reorganize metadata types #6103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit 9ce7e15 |
-> Remove traces of multi source related types -> Use ordered hashmaps and hashsets in 'Metadata' type
rakeshkky
force-pushed
the
5797-metadata-class
branch
from
9ce7e15
to
7401802
Compare
rakeshkky
reviewed
Nov 2, 2020
| @@ -72,86 +72,12 @@ runClearMetadata _ = do | |||
| buildSchemaCacheStrict | |||
| return successMsg | |||
|
|
|||
| applyQP1 | |||
There was a problem hiding this comment.
The logic this function does has been moved to parseJSON of the Metadata type. See parseListAsMap function.
tirumaraiselvan
approved these changes
Nov 3, 2020
scriptonist
pushed a commit
to scriptonist/graphql-engine
that referenced
this pull request
Nov 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an incremental PR towards #5797. It refactors metadata types that will be used to incrementally modify the metadata.
It also adds a big type class inThis change will be made in subsequent incremental PR.Hasura.Classthat will be used as a general interface for providing a metadata API. We may want to discuss this type class in some more detail, to decide whether it follows a design pattern we'd like to include in our code base, or if it needs further thought.Although this PR adds types that can hold new metadata, the intention is that it does not change what metadata actually gets stored. Any new style metadata code included should not be used. However, we should check this carefully.
Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR. If no changelog is required, then add theno-changelog-requiredlabel.Affected components
Related Issues
Solution and Design
Steps to test and verify
Limitations, known bugs & workarounds
Server checklist
Catalog upgrade
Does this PR change Hasura Catalog version?
Metadata
Does this PR add a new Metadata feature?
GraphQL
Breaking changes