Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT | Security | ABEMA-904: Enabled ability to disable URL Caching #29

Merged
merged 1 commit into from
Apr 5, 2018

Conversation

awall1
Copy link
Contributor

@awall1 awall1 commented Apr 4, 2018

Putting this in won't require changes and won't affect your project.
I've created and exposed an isURLCachingEnabled flag to allow for disabling URL Caching.
This comes as a security request from a client that doesn't want all of our requests cached in the device's cache.db.

@hathwaybot
Copy link

Danger has errored

[!] Invalid Dangerfile file: �[31mError creating your coverage report - see the log above�[0m. Updating the Danger gem might fix the issue. Your Danger version: 5.5.10, latest Danger version: 5.5.11

 #  from Dangerfile:2
 #  -------------------------------------------
 #  # Test coverage report
 >  xcov.report(
 #     scheme: 'JSONRequest',
 #  -------------------------------------------

Generated by 🚫 Danger

@misterwell
Copy link
Contributor

R+

@awall1
Copy link
Contributor Author

awall1 commented Apr 5, 2018

Double checking with testing first before merging 👍

@awall1 awall1 merged commit 26d6a18 into master Apr 5, 2018
@misterwell misterwell deleted the maint/Ability-to-disable-caching branch September 10, 2018 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants