Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT | Security | ABEMA-904: Enabled ability to disable URL Caching #29

Merged
merged 1 commit into from
Apr 5, 2018
Merged

MAINT | Security | ABEMA-904: Enabled ability to disable URL Caching #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Sources/JSONRequest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ open class JSONRequest {
open static var requestCachePolicy: NSURLRequest.CachePolicy = .useProtocolCachePolicy {
didSet { updateSessionConfig() }
}
open static var isURLCacheEnabled: Bool = true {
didSet { updateSessionConfig() }
}

open static let serviceTripTimeNotification = NSNotification.Name("JSON_REQUEST_TRIP_TIME_NOTIFICATION")

Expand Down Expand Up @@ -125,7 +128,7 @@ open class JSONRequest {
sessionConfig.timeoutIntervalForResource = resourceTimeout
sessionConfig.timeoutIntervalForRequest = requestTimeout
let capacity: Int = (maxEstimatedResponseMegabytes * 20) * 1024 * 1024 // max response should be less than 5% of cache size
let urlCache = URLCache(memoryCapacity: capacity, diskCapacity: capacity, diskPath: nil)
let urlCache: URLCache? = isURLCacheEnabled ? URLCache(memoryCapacity: capacity, diskCapacity: capacity, diskPath: nil) : nil
sessionConfig.urlCache = urlCache
urlSession = URLSession(configuration: JSONRequest.sessionConfig)
}
Expand Down