Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No colors in tui #209

Closed
Vanav opened this issue Feb 8, 2023 · 3 comments · Fixed by #218
Closed

No colors in tui #209

Vanav opened this issue Feb 8, 2023 · 3 comments · Fixed by #218
Labels
bug Something isn't working

Comments

@Vanav
Copy link

Vanav commented Feb 8, 2023

I don't see colors in tui (#187) for some reason:
image

Also notice that progress bar is invisible in "color" mode.

oha v0.5.6 (amd64 build from Releases page), Ubuntu 22 / Debian 11, TERM=xterm-256color.
Ternimal has no issues with colors, even oha displays some colors:
image

@hatoo hatoo added the bug Something isn't working label Feb 8, 2023
@hatoo
Copy link
Owner

hatoo commented Feb 25, 2023

I couldn't reproduce it.
Could you put the name of the terminal app you've used and test it on another terminal app?

@Vanav
Copy link
Author

Vanav commented Feb 25, 2023

I did some tests: colors only appear if I enable "True Colors" (24 bit) support in terminal, "ANSI with 256 colors" is not enough. Seems you are sending True Color sequences, that are out of scope of 256 colors.

I think, for this simple case 256 colors should be enough, like most other apps use. Maybe better to limit to 256 colors?

I use SecureCRT.

@hatoo
Copy link
Owner

hatoo commented Feb 25, 2023

Thanks!
It seems that the current implementation requires True Color because it uses RGB variant of https://docs.rs/tui/0.19.0/tui/style/enum.Color.html
I'll fix it soon.

@hatoo hatoo mentioned this issue Feb 27, 2023
@hatoo hatoo mentioned this issue Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants