Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow update #128

Closed
relekang opened this issue Sep 5, 2018 · 5 comments
Closed

workflow update #128

relekang opened this issue Sep 5, 2018 · 5 comments
Assignees

Comments

@relekang
Copy link
Collaborator

relekang commented Sep 5, 2018

It would be nice to be able to update all workflow packages in workflow home with a simple command.

$ workflow update
The following will be updated:
  · workflow-core          1.0.0 -> 1.1.0
  · workflow-app-chrome    1.0.1 -> 1.0.2
Are you sure? (y/N)
@havardh havardh added the cli label Sep 5, 2018
@havardh havardh changed the title workflow --update workflow update Sep 5, 2018
@havardh
Copy link
Owner

havardh commented Sep 5, 2018

@relekang I've updated the description and title to match #89

@havardh
Copy link
Owner

havardh commented Sep 5, 2018

Should we move to ~ dependencies and make this run npm update ?

And concerning packaging for this and future commands, we have a few options:

  1. Implement this as part of workflow-cmd.
  2. Implement this as workflow-cmd-update or workflow-update and call it from workflow.
  3. Implement this as workflow-cmd-update or workflow-update and call if from workflow-cmd.

I'm leaning towards (3) and the possibility of extracting workflow-cmd/src/index into workflow-cmd-apply. Thus leaving the workflow-cmd with the responsibility of choosing the command and executing the appropriate package, defaulting to apply.

@relekang
Copy link
Collaborator Author

relekang commented Sep 5, 2018

I don't understand what the benefits of separating workflow-cmd into different packages vs files in the workflow-cmd package. Can you elaborate?

@relekang
Copy link
Collaborator Author

relekang commented Sep 5, 2018

Should we move to ~ dependencies and make this run npm update ?

Don't think it will give us the overview and make it possible to ask the question. I was thinking, maybe see if we can use npm-check-updates or something like a library.

@havardh
Copy link
Owner

havardh commented Sep 5, 2018

I don't understand what the benefits of separating workflow-cmd into different packages vs files in the workflow-cmd package. Can you elaborate?

Maybe just an old habit to separate things, but as you say, there are not any real benefits for doing so at this point.

Don't think it will give us the overview and make it possible to ask the question. I was thinking, maybe see if we can use npm-check-updates or something like a library.

Sure, I was thinking of doing npm outdated and then npm update. But if there is a library that solves this, then we can go with it 👍

@havardh havardh self-assigned this Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants