Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed attack skating changed troy's jump back to its original #1059

Merged
merged 1 commit into from Mar 24, 2013

Conversation

NimbusBP1729
Copy link
Member

the most important part of being troy is his jump

NimbusBP1729 added a commit that referenced this pull request Mar 24, 2013
removed attack skating changed troy's jump back to its original
@NimbusBP1729 NimbusBP1729 merged commit 2c5fe66 into hawkthorne:master Mar 24, 2013
@NimbusBP1729 NimbusBP1729 deleted the animation_tweaks branch March 24, 2013 06:01
@jhoff
Copy link
Member

jhoff commented Mar 24, 2013

Can you explain the changes to character_map.lua more indepth? Changing this file effects most characters, and if the default for these is to change 'once' to 'loop' then any where those are overridden should be updated too.

@NimbusBP1729
Copy link
Member Author

i sure can. This essentially reverts the code back to the pre-sprite normalization conditions. When you made an attack it would just loop through the animations rather than just play once. What the code did without this would do the attack animation, then any subsequent time it would just display the final frame of that attack animation.

for wieldaction this makes it so that while running the characters legs also move when the swing a weapon rather than freezing in a specific position. I thout this change was necessary when I saw a video that mentioned/critiqued this.

@jhoff
Copy link
Member

jhoff commented Mar 24, 2013

Ok sounds good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants