Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes projectile quantity when dropped #1633

Merged
merged 3 commits into from
Jul 17, 2013

Conversation

Protuhj
Copy link
Contributor

@Protuhj Protuhj commented Jul 5, 2013

If you dropped a non-full stack of projectiles, when you picked it up again, the stack would re-fill.

@danhp
Copy link
Member

danhp commented Jul 5, 2013

I'm not sure if this changed anything.
I still get inconsistent drop amounts.

EDIT: This works fine but not with cheats (money and the shopping or even the straight up cheat)
i'm guessing shopping is not giving the correct items.

so technically mergeable as is. we have to create separate issues for the shopping

@CalebJohn
Copy link
Member

I'm not going to be able to test until later tonight but since these are related, @Protuhj do you think this could be adjusted to fix #1570 as well?

@Protuhj
Copy link
Contributor Author

Protuhj commented Jul 6, 2013

I won't be able to test this further until Sunday. If you want to expand on
this to address the stacked items, feel free.

@CalebJohn
Copy link
Member

@Protuhj @daniwa I don't think it's related to cheats I think its the way the blacksmith gives items but this definitely only works sometimes.

The quantity will now be stored in the node when dropped
@ghost ghost assigned Protuhj Jul 13, 2013
@danhp
Copy link
Member

danhp commented Jul 13, 2013

works great!
if you push this fix to weapons, it's ranged counterpart and scrolls, you'll also get #1570 in one go

Although the other nodes don't currently make sense to drop multiples,
another one in the future might.
@CalebJohn
Copy link
Member

LGTM
and I must say I am a fan of the comments

@Protuhj
Copy link
Contributor Author

Protuhj commented Jul 15, 2013

Let's get another developer to test and sign off on this so we can merge it.

danhp added a commit that referenced this pull request Jul 17, 2013
Fixes projectile quantity when dropped
@danhp danhp merged commit 82f0ef9 into hawkthorne:master Jul 17, 2013
@danhp danhp mentioned this pull request Jul 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants