Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit chart - No numeric metrics available! #263

Closed
davsclaus opened this issue Apr 19, 2013 · 13 comments
Closed

Edit chart - No numeric metrics available! #263

davsclaus opened this issue Apr 19, 2013 · 13 comments

Comments

@davsclaus
Copy link
Member

When trying to edit the charts for Camel plugin, then I get that information all the time.
I think we had that issue in the past as well.

See screenshot.

Screen Shot 2013-04-19 at 8 26 41 AM

@jstrachan
Copy link
Contributor

hmmm - seems to work here. Wonder if its browser related?

@janstey
Copy link
Member

janstey commented Apr 23, 2013

For me it only works the first time you click edit chart. Every other time it displays the "No numeric metrics available!" message.

@jstrachan
Copy link
Contributor

I wonder if its to do with query arguments on the URL hanging around. Which URL does it not work on? Any chance you could post a URL that doesn't work?

@jstrachan
Copy link
Contributor

Ah yeah - I think thats the issue - if you chart 1 mbean, then go to a completely different mbean that doesn't have any of the old attribute names, then it thinks there's no attributes to view any more (as none of them are valid).

Lemme try fix...

@jstrachan
Copy link
Contributor

Having said that - even in this case, I can then click on the Edit Chart link and pick whatever attributes I want again.

Its a bit tricky knowing when to trash the attr / el query attributes really. Maybe we should do that whenever we change mbean selection to a different type or something?

@janstey
Copy link
Member

janstey commented Apr 23, 2013

Not sure when to discard though args :-) When I load a different tab (eg. ActiveMQ) and go back to Camel I can then again view the edit chart page. If it helps, I'm running this on the JBoss Fuse 6 GA kit and loaded an example + hawtio like so:

osgi:install -s fab:mvn:org.jboss.fuse.examples/jms/6.0.0.redhat-024
features:addurl mvn:io.hawt/hawtio-karaf/1.2-SNAPSHOT/xml/features
features:install hawtio

@jstrachan
Copy link
Contributor

Any chance you could copy and paste the URL here when you're on a page that doesn't work? So we can work out bad combinations of URLs to test against?

@jstrachan
Copy link
Contributor

BTW a little secret trick I use now and again; to reset all the query arguments, click on the 'hawtio' link on the top left of the nav bar :)

jstrachan added a commit that referenced this issue Apr 23, 2013
…n MBean (e.g. for camel routes which have child nodes) so lets only take the first node if its an mbean
jstrachan added a commit that referenced this issue Apr 23, 2013
…in with the 'att' search argument on the URL and they don't match any attributes on this mbean (e.g. if they are from a different mbean) then ignore them and just use all the numeric attributes until folks click the "Edit Chart" button
@jstrachan
Copy link
Contributor

OK I"ve a partial fix for this now I think; at least in the case where the attr=Foo attribute names don't match anything on the current MBean we ignore them and chart all the attributes. The Edit Chart view was broken a little bit due to the Route nodes in the Camel tree having children as well (so they were kinda treated as a folder of mbeans). Fixed that too now

@jstrachan
Copy link
Contributor

I think I've fixed this now; let me know if it doesn't work for you. Tried all the permutations I could think of; we basically now try to ignore duff attribute selections from some mbeans being used to chart other mbeans.

Incidentally if you can reproduce some oddness, it'd really help knowing which URLs go wonky; i.e. which selections of things break (folders or mbeans) and which parameters were being passed in (e.g. the 'el' and 'att' query attributes).

Fingers crossed this really is fixed now though! :)

@janstey
Copy link
Member

janstey commented Apr 23, 2013

Yep you fixed it. Works perfectly now :-) Thanks!

@jstrachan
Copy link
Contributor

Awesome - phew! :)

paoloantinori pushed a commit to paoloantinori/hawtio that referenced this issue Jun 27, 2017
[PATCH-1488] ENTMQ-1987: Include destination query functionality into the product
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants