Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hawtio-git feature - Can we avoid fab protocol #737

Closed
davsclaus opened this issue Nov 9, 2013 · 5 comments
Closed

hawtio-git feature - Can we avoid fab protocol #737

davsclaus opened this issue Nov 9, 2013 · 5 comments

Comments

@davsclaus
Copy link
Member

Installed hawtio feature in karaf 2.3.3

Now clicked on the hawtio-git feature to install as well from the osgi plugin. But got the error about unknown protocol: fab

Wonder if we can make hawtio not rely on fab?

screen shot 2013-11-09 at 10 24 28 am

@ghost ghost assigned davsclaus Nov 9, 2013
@davsclaus
Copy link
Member Author

We need an osgi bundle: https://issues.apache.org/jira/browse/SMX4-1622

@jstrachan
Copy link
Contributor

I guess we could embed that inside hawtio-git?

@jstrachan
Copy link
Contributor

so maybe hawtio-git just needs to embed/export com.jcraft, org.gitective, javaewah and be a regular bundle? then its only dependency would be jgit

@davsclaus
Copy link
Member Author

Yeah i spend several hours yesterday and got into osgi hell. the jgit has a osgi import on jcraft, but also on its symbolic bundle name, so we cannot use the SMX wrapped bundle as it has a different symbolic name and you cannot override that - eg jcraft must be embedded somehow so jgit can use it.

And then later on some weird errors about OSGI-INF/blueprint/osgi.xml not found and whatnot.

@jstrachan
Copy link
Contributor

OK after an hour or so mucking about with the maven bundle plugin; I'm getting closer. I think due to the jgit having an import bundle on org.jcraft.jsch which doesn't exist any where in a maven repo with that bundle name - we have to embed jgit inside hawtio-git to make an uber bundle for git (I notice that fabric-git does the same too - one day we could make a jgit / uber bundle maybe so we could share?).

Almost done then will commit...

jstrachan added a commit that referenced this issue Jan 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants