Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traces in engine code #30

Closed
Gama11 opened this issue Jan 11, 2014 · 5 comments
Closed

Traces in engine code #30

Gama11 opened this issue Jan 11, 2014 · 5 comments

Comments

@Gama11
Copy link
Member

Gama11 commented Jan 11, 2014

I'm not a fan of having traces in engine code. I made sure they are all encased by debug-conditionals, but still, that doesn't really solve the issue - personally, it would annoy me to no end that my own traces are lost in the flood of the engine's own traces.

Two options:

  • Remove them entirely
  • Create a flag like FlxUI.debug to toggle them (not a fan of introducing new compiler conditionals where not necessary)
@gamedevsam
Copy link
Contributor

Where are there traces in engine code? Did I accidentally leave some debug code?

@larsiusprime
Copy link
Member

Probably my fault. I'll see if I can track them down and fix them.

@Gama11
Copy link
Member Author

Gama11 commented Jan 11, 2014

@crazysam We're talking about flixel-ui here.

@larsiusprime Finding them is pretty easy via FD's find and replace. But I thought they might be there intentionally?

@larsiusprime
Copy link
Member

Just a bad habit of mine. They can be removed, hidden behind debug flags,
or switched to FlxG.log

On Sat, Jan 11, 2014 at 1:37 PM, Gama11 notifications@github.com wrote:

@crazysam https://github.com/crazysam We're talking about flixel-ui
here.

@larsiusprime https://github.com/larsiusprime Finding them is pretty
easy via FD's find and replace. But I thought they might be there
intentionally?


Reply to this email directly or view it on GitHubhttps://github.com//issues/30#issuecomment-32104843
.

www.fortressofdoors.com -- Games, Art, Design

@Gama11
Copy link
Member Author

Gama11 commented Jan 11, 2014

Alright. Do whatever works for you! :)

@Gama11 Gama11 closed this as completed in 4fc1de6 Jan 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants