Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modding D2 via text files doesn't work #3

Open
ubeogesh opened this issue May 31, 2020 · 7 comments
Open

Modding D2 via text files doesn't work #3

ubeogesh opened this issue May 31, 2020 · 7 comments

Comments

@ubeogesh
Copy link

ubeogesh commented May 31, 2020

To reproduce

  1. Make a simple D2 mod with some text file change, for example:
  • Change data\global\excel\armor.txt file. Make some obvious change, for example change graphics for cap to use graphics of skull cap (in 2nd line, V column change value to skp)
  1. In plugy.ini set up Param= -direct -txt
  2. Start PlugY

Result:

The changes don't take effect. The game has recognized the command line - it has spawned *.bin files in the \excel\ folder; and I have checked game.exe in process explorer - it was started with with "-w -direct -txt" parameters; but the change that was made doesn't happen.

@skylight102
Copy link

Please resolve this, I am experiencing the same problem, thank you.

1 similar comment
@marklove5102
Copy link

marklove5102 commented Jul 9, 2020

Please resolve this, I am experiencing the same problem, thank you.

@ghost
Copy link

ghost commented Nov 11, 2020

I have been looking into this and have found the following function is causing this issue. If I remark out where this function is called then txt files in \data\global\excel work. Looking at the code it looks like it was a work in progress.

`void Install_PlugYFiles()
{
static int isInstalled = false;
if (isInstalled) return;

log_msg("Patch Storm to found custom file. (PlugYFiles)\n");

// Try in Diablo II\PlugY\ if file not found
mem_seek R8(Storm,	192C6, 19296, 18677, 2CC69, 14259, 121E9, 28D89, 2DA79, 19369);//( (DWORD)D2Storm268 + V7(Storm, 01A8, 01A8, 01AB, 0429, 0429, 0429, 0000) );
memt_byte( version_D2Client == V114d ? 0x8D : 0xFF ,0x90); // NOP
memt_byte( version_D2Client == V114d ? 0x85 : 0x15 ,0xE8); // CALL
if (version_Storm == V114d) {
    MEMT_REF4(0xFFFFFEF8, caller_isModFile_114);
} else {
    MEMD_REF4(LeaveCriticalSection, version_Storm == V114d ? caller_isModFile_114 : version_Storm >= V111 ? caller_isModFile_111 : caller_isModFile);
}
//6FFC8677  |. FF15 F411FE6F  CALL DWORD PTR DS:[<&KERNEL32.LeaveCriti>; \LeaveCriticalSection
//6FC1CC69  |. FF15 3832C36F  CALL DWORD PTR DS:[<&KERNEL32.LeaveCriti>; \LeaveCriticalSection
//6FC04259  |. FF15 3832C36F  CALL DWORD PTR DS:[<&KERNEL32.LeaveCriti>; \LeaveCriticalSection
//6FC021E9  |. FF15 4432C36F  CALL DWORD PTR DS:[<&KERNEL32.LeaveCriti>; \LeaveCriticalSection
//6FC18D89  |. FF15 5832C36F  CALL DWORD PTR DS:[<&KERNEL32.LeaveCriti>; \LeaveCriticalSection
//6FC1DA79  |. FF15 3C32C36F  CALL DWORD PTR DS:[<&KERNEL32.LeaveCriti>; \LeaveCriticalSection


log_msg("\n" );

isInstalled = true;

}`

@ghost
Copy link

ghost commented Nov 14, 2020

I have fixed this ready for testing.

@ChaosMarc
Copy link

Now fixed on https://github.com/ChaosMarc/PlugY. @markm11 Thank you very much. I will create a new release with a precompiled binary very soon

@jonselin
Copy link

I'm still experiencing this issue on 14.01

@ChaosMarc
Copy link

ChaosMarc commented Jan 14, 2021

Please open an issue in my repo for that. Haxifix has nothing to do with 14.01

edit: and I just tested it. I have no problems loading my changes from data/global/excel:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants