Sample Pull Request #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
review-dog
reviewed
Oct 23, 2016
| @@ -36,6 +40,8 @@ type CheckResult struct { | |||
| Lines []string // Original error lines (often one line) | |||
| } | |||
|
|
|||
| var vetError = fmt.Sprintf("", 1, 2, 3) // TODO: revert | |||
There was a problem hiding this comment.
[govet] reported by reviewdog 🐶
no formatting directive in Sprintf call
review-dog
reviewed
Oct 23, 2016
| @@ -21,11 +21,15 @@ type Reviewdog struct { | |||
| d DiffService | |||
| } | |||
|
|
|||
| var ExportedVarWithoutComment = 1 // TODO: revert | |||
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported var ExportedVarWithoutComment should have comment or be unexported
review-dog
reviewed
Oct 23, 2016
| @@ -36,6 +40,8 @@ type CheckResult struct { | |||
| Lines []string // Original error lines (often one line) | |||
| } | |||
|
|
|||
| var vetError = fmt.Sprintf("", 1, 2, 3) // TODO: revert | |||
There was a problem hiding this comment.
reported by reviewdog 🐶
var vetError is unused
review-dog
reviewed
Oct 23, 2016
| // NewReviewdog returns a new Reviewdog. | ||
| func NewReviewdog(toolname string, p Parser, c CommentService, d DiffService) *Reviewdog { | ||
| return &Reviewdog{p: p, c: c, d: d, toolname: toolname} | ||
| } | ||
|
|
||
| var unusedVar = 2 // TODO: revert |
There was a problem hiding this comment.
reported by reviewdog 🐶
var unusedVar is unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.