Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on config #72

Closed
hayd opened this issue Sep 17, 2014 · 1 comment
Closed

Feedback on config #72

hayd opened this issue Sep 17, 2014 · 1 comment
Labels
Milestone

Comments

@hayd
Copy link
Owner

hayd commented Sep 17, 2014

At the moment it looks at default (home config) then updates with local configs (.pep8 etc) then updates with passed in arguments. See #71.

Was hoping for feedback before pushing release...

Concerns:

  • This may raise if there are bad config files. Personally I think this is a good thing.
  • If you are using a projects config perhaps you don't want to dirty it with your own? (currently if configs are not set locally then defaults are from the user's config). I'm unsure about this behaviour.
@hayd hayd added the question label Sep 17, 2014
@hayd hayd added this to the 0.9 milestone Sep 17, 2014
@hayd hayd modified the milestones: 0.9.1, 0.9 Sep 19, 2014
@hayd
Copy link
Owner Author

hayd commented Sep 21, 2014

Thinking of changing API slightly (but will match whatever autopep8 decides), to have --global-config and --ignore-local-config for the following behaviour:

  • if --global-config use this path as global_config
  • else set global_config to DEFAULT_CONFIG
  • update parser with global_config (if file is missing this does nothing)
  • if not passed --ignore-local-config then update parser with local config (found with parent-tail in autopep8, just looking in root dir here)
  • update with passed in arguments

@hayd hayd closed this as completed Oct 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant