Move merkle tree and event journal config inside map and cache config #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2019
In 4.0 we move the EventJournalConfig and MerkleTreeConfig inside MapConfig and CacheConfig. Up until 4.0 there were top-level configurations because CacheConfig was a BinaryInterface. Also, because they are part of MapConfig and CacheConfig, they will no longer have the mapName and cacheName fields. Depends on: hazelcast/hazelcast#15185
|
@sancar @ihsandemir are you ok with this PR, anything that I would need to change? |
asimarslan
pushed a commit
that referenced
this pull request
Jul 31, 2019
asimarslan
pushed a commit
to asimarslan/hazelcast-client-protocol
that referenced
this pull request
Aug 9, 2019
asimarslan
pushed a commit
that referenced
this pull request
Aug 9, 2019
|
Backported to new protocol branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 4.0 we move the EventJournalConfig and MerkleTreeConfig inside
MapConfig and CacheConfig. Up until 4.0 there were top-level
configurations because CacheConfig was a BinaryInterface.
Also, because they are part of MapConfig and CacheConfig, they will no
longer have the mapName and cacheName fields.
Depends on:
hazelcast/hazelcast#15185
hazelcast/hazelcast#15226