Fix address util test for loopback of ipv6 #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srknzl
force-pushed
the
fix-addressutil-test
branch
from
7fdd968
to
7c8ffc7
Compare
srknzl
force-pushed
the
fix-addressutil-test
branch
from
7c8ffc7
to
febba59
Compare
Codecov Report
@@ Coverage Diff @@
## master #1095 +/- ##
==========================================
- Coverage 92.43% 92.20% -0.23%
==========================================
Files 433 433
Lines 14428 14428
Branches 1048 1048
==========================================
- Hits 13337 13304 -33
- Misses 808 840 +32
- Partials 283 284 +1
Continue to review full report at Codecov.
|
|
verify |
mdumandag
approved these changes
Oct 22, 2021
Co-authored-by: Metin Dumandag <metindumandag@gmail.com>
srknzl
added a commit
to srknzl/hazelcast-nodejs-client
that referenced
this pull request
Jan 31, 2022
* Fix address util test for loopback of ipv6 * Delete `.be` s Co-authored-by: Metin Dumandag <metindumandag@gmail.com> Co-authored-by: Metin Dumandag <metindumandag@gmail.com>
srknzl
added a commit
to srknzl/hazelcast-nodejs-client
that referenced
this pull request
Jan 31, 2022
* Fix address util test for loopback of ipv6 * Delete `.be` s Co-authored-by: Metin Dumandag <metindumandag@gmail.com> Co-authored-by: Metin Dumandag <metindumandag@gmail.com>
srknzl
added a commit
to srknzl/hazelcast-nodejs-client
that referenced
this pull request
Jan 31, 2022
* Fix address util test for loopback of ipv6 * Delete `.be` s Co-authored-by: Metin Dumandag <metindumandag@gmail.com> Co-authored-by: Metin Dumandag <metindumandag@gmail.com>
srknzl
added a commit
to srknzl/hazelcast-nodejs-client
that referenced
this pull request
Jan 31, 2022
* Fix address util test for loopback of ipv6 * Delete `.be` s Co-authored-by: Metin Dumandag <metindumandag@gmail.com> Co-authored-by: Metin Dumandag <metindumandag@gmail.com>
srknzl
added a commit
that referenced
this pull request
Feb 21, 2022
* Fix address util test for loopback of ipv6 (#1095) * Fix address util test for loopback of ipv6 * Delete `.be` s Co-authored-by: Metin Dumandag <metindumandag@gmail.com> Co-authored-by: Metin Dumandag <metindumandag@gmail.com> * Add CI workflow * Add chai as promised to addressutiltest Co-authored-by: Metin Dumandag <metindumandag@gmail.com>
srknzl
added a commit
that referenced
this pull request
Feb 21, 2022
srknzl
added a commit
that referenced
this pull request
Feb 21, 2022
* Fix address util test for loopback of ipv6 (#1095) * Fix address util test for loopback of ipv6 * Delete `.be` s Co-authored-by: Metin Dumandag <metindumandag@gmail.com> Co-authored-by: Metin Dumandag <metindumandag@gmail.com> * Add CI workflow * Remove junit reporter and add chai as promised plugin to addressutiltest Co-authored-by: Metin Dumandag <metindumandag@gmail.com>
harunalpak
pushed a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Dec 8, 2022
* Fix address util test for loopback of ipv6 * Delete `.be` s Co-authored-by: Metin Dumandag <metindumandag@gmail.com> Co-authored-by: Metin Dumandag <metindumandag@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems
dns.lookupwill return ipv6 ip address. I fix the test by changing assertion to assert ip is either ipv6 loopback address or ipv4 loopback address.Also I realized that the eslint config line-break makes it really hard to work on windows. There are a lot of warning in the open file while writing code. So I deleted it.
I am not sure if the
resolveAddressmethod should return only ipv4, I don't think so.Example fail https://github.com/hazelcast/hazelcast-nodejs-client/runs/3958991705?check_suite_focus=true
Seems like with node 17 dns lookup returns ipv6 loopback when localhost is given.