Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0.x] Fix address util test for loopback of ipv6 API-1193 #1181

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

srknzl
Copy link
Member

@srknzl srknzl commented Jan 31, 2022

Clean cherry-pick backport of #1095

The original PR was fixing a unit test so we need to backport it to all branches.

* Fix address util test for loopback of ipv6

* Delete `.be` s

Co-authored-by: Metin Dumandag <metindumandag@gmail.com>

Co-authored-by: Metin Dumandag <metindumandag@gmail.com>
@srknzl srknzl added this to the 5.0.4 milestone Jan 31, 2022
@srknzl srknzl changed the title Fix address util test for loopback of ipv6 (#1095) [5.0.x] Fix address util test for loopback of ipv6 (#1095) Jan 31, 2022
@srknzl srknzl changed the title [5.0.x] Fix address util test for loopback of ipv6 (#1095) [5.0.x] Fix address util test for loopback of ipv6 Jan 31, 2022
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #1181 (30a1db1) into 5.0.x (fdee35d) will decrease coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            5.0.x    #1181      +/-   ##
==========================================
- Coverage   92.63%   92.20%   -0.43%     
==========================================
  Files         438      438              
  Lines       16844    16844              
  Branches     1076     1076              
==========================================
- Hits        15603    15531      -72     
- Misses        958     1027      +69     
- Partials      283      286       +3     
Impacted Files Coverage Δ
src/codec/ClientAuthenticationCustomCodec.ts 40.42% <0.00%> (-34.05%) ⬇️
src/network/ConnectionManager.ts 77.57% <0.00%> (-8.69%) ⬇️
src/nearcache/RepairingTask.ts 89.70% <0.00%> (-2.95%) ⬇️
src/config/ConfigBuilder.ts 93.82% <0.00%> (-2.78%) ⬇️
src/invocation/ClusterService.ts 92.19% <0.00%> (-0.71%) ⬇️
src/proxy/MultiMapProxy.ts 97.14% <0.00%> (-0.58%) ⬇️
src/util/Util.ts 88.05% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdee35d...30a1db1. Read the comment docs.

@srknzl srknzl changed the title [5.0.x] Fix address util test for loopback of ipv6 [5.0.x] Fix address util test for loopback of ipv6 API-1193 Jan 31, 2022
@srknzl srknzl requested review from yuce and removed request for zpqrtbnk February 21, 2022 10:10
@srknzl srknzl merged commit d2030c1 into hazelcast:5.0.x Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants