Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2.x] Fix address util test for loopback of ipv6 API-1193 #1182

Merged
merged 3 commits into from
Feb 21, 2022

Conversation

srknzl
Copy link
Member

@srknzl srknzl commented Jan 31, 2022

  • Clean cherry-pick backport of Fix address util test for loopback of ipv6 #1095 . The original PR was fixing a unit test so we need to backport it to all branches.
  • Also adds CI yaml. After we switch to github actions we did not add workflow files to older branches.
  • Also add chai as promised plugin to the test. I think it was working since chai plugins are cached inside so that using it in one test is enough, so this test passed since other tests included the plugin. It was failing when run solely.

* Fix address util test for loopback of ipv6

* Delete `.be` s

Co-authored-by: Metin Dumandag <metindumandag@gmail.com>

Co-authored-by: Metin Dumandag <metindumandag@gmail.com>
@srknzl srknzl added this to the 4.2.2 milestone Jan 31, 2022
@srknzl srknzl changed the title [4.2.x] Fix address util test for loopback of ipv6 (#1095) [4.2.x] Fix address util test for loopback of ipv6 Jan 31, 2022
@srknzl srknzl changed the title [4.2.x] Fix address util test for loopback of ipv6 [4.2.x] Fix address util test for loopback of ipv6 API-1193 Jan 31, 2022
@srknzl srknzl requested review from yuce and removed request for zpqrtbnk February 21, 2022 10:09
@srknzl srknzl merged commit 299d92e into hazelcast:4.2.x Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants