Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed network configuration examples #362

Merged
merged 2 commits into from Oct 26, 2017

Conversation

kwart
Copy link
Member

@kwart kwart commented Oct 26, 2017

@kwart kwart self-assigned this Oct 26, 2017
@kwart kwart requested a review from Serdaro October 26, 2017 07:03
@kwart kwart changed the title Fixed setPublicAddress() call example Fixed network configuration examples Oct 26, 2017
@kwart
Copy link
Member Author

kwart commented Oct 26, 2017

I've also added a second commit which simplifies the auto-increment description and makes the example more real-life like.

…ing argument.

Fixed port configuration example - String->int, removed semicolon, setPortCount() doesn't support fluent API (see hazelcast/hazelcast#11669).
Copy link
Contributor

@Serdaro Serdaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Serdaro Serdaro merged commit 158b779 into hazelcast:master Oct 26, 2017
@kwart kwart deleted the typo-setPublicAddress branch November 16, 2017 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants