Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let NetworkConfig.setPortCount() return the NetworkConfig instance #11669

Closed
kwart opened this issue Oct 26, 2017 · 1 comment · Fixed by #15443
Closed

Let NetworkConfig.setPortCount() return the NetworkConfig instance #11669

kwart opened this issue Oct 26, 2017 · 1 comment · Fixed by #15443
Labels
Estimation: S Internal breaking change Priority: Medium Source: Internal PR or issue was opened by an employee Team: Core Type: Cleanup Type: Enhancement
Milestone
4.0

Comments

@kwart
Copy link
Member

kwart commented Oct 26, 2017

The NetworkConfig.setPortCount(int) doesn't return this instance compared to other setter methods in the class.

So it can't be used in the middle of a fluent API network configuration.
kwart added a commit to kwart/hazelcast-reference-manual that referenced this issue Oct 26, 2017
@kwart
Fixed setPublicAddress() call example - the method takes just one Str…
421fce2 
…ing argument.

Fixed port configuration example - String->int, removed semicolon, setPortCount() doesn't support fluent API (see hazelcast/hazelcast#11669).
@kwart kwart mentioned this issue Oct 26, 2017
Merged
@mmedenjak
Copy link
Contributor

There was already a discussion on fixing the fluent API for other caches. See discussion: #11107

kwart added a commit to kwart/hazelcast-reference-manual that referenced this issue Oct 26, 2017
@kwart
Fixed setPublicAddress() call example - the method takes just one Str…
92ebd10 
…ing argument.

Fixed port configuration example - String->int, removed semicolon, setPortCount() doesn't support fluent API (see hazelcast/hazelcast#11669).
@mmedenjak mmedenjak added this to the 4.0 milestone Nov 10, 2017
@burakcelebi burakcelebi added the Source: Internal PR or issue was opened by an employee label Jun 21, 2018
@mmedenjak mmedenjak mentioned this issue Jul 6, 2018
Closed
mmedenjak pushed a commit to mmedenjak/hazelcast that referenced this issue Aug 10, 2019
Fix fluent API for config classes
9966257 
Setters and other modification methods should try to return the same
instance for a fluent API.

Fixes: hazelcast#11669
@mmedenjak mmedenjak mentioned this issue Aug 10, 2019
Merged
mmedenjak pushed a commit to mmedenjak/hazelcast that referenced this issue Sep 4, 2019
Fix fluent API for config classes
17b2c37 
Setters and other modification methods should try to return the same
instance for a fluent API.

Fixes: hazelcast#11669
mmedenjak added a commit that referenced this issue Sep 20, 2019
@mmedenjak
Fix fluent API for config classes (#15443)
a90b982 
Fix fluent API for config classes

Setters and other modification methods should try to return the same
instance for a fluent API.

Fixes: #11669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Estimation: S Internal breaking change Priority: Medium Source: Internal PR or issue was opened by an employee Team: Core Type: Cleanup Type: Enhancement
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Fix fluent API for config classes mmedenjak/hazelcast
4 participants
@burakcelebi @kwart @dbrimley @mmedenjak