Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ommited timeToLiveSeconds value #12276

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Fixed ommited timeToLiveSeconds value #12276

merged 1 commit into from
Feb 13, 2018

Conversation

mumukiller
Copy link
Contributor

@mumukiller mumukiller commented Feb 7, 2018 •
edited
Loading

Added missed timeToLiveSeconds value
Related test was fixed

#12273

@mumukiller mumukiller changed the title Fixed ommiting timeToLiveSeconds value Fixed ommited timeToLiveSeconds value Feb 7, 2018
@vbekiaris
Copy link
Contributor

run-lab-run

@vbekiaris
Copy link
Contributor

@mumukiller before we merge your fix, can you please sign the Hazelcast Contributor Agreement and send it to the email listed on the web page?

@vbekiaris
Copy link
Contributor

Also, can you backport the change to maintenance-3.x branch so the fix will be merged for an upcoming 3.9.4 release?

@mumukiller
Copy link
Contributor Author

@vbekiaris agreement was sent

@mumukiller
Copy link
Contributor Author

@vbekiaris are there any docs related to backporting process?

@vbekiaris
Copy link
Contributor

@mumukiller you just need to create a new branch in your local git repos off of maintenance-3.x, then apply the same changes in this PR (maybe you will be able to cherry pick your commit, I think these classes haven't changed much). Then, while creating the new pull request, select hazelcast:maintenance-3.x as the target branch to merge to.

@mumukiller
Copy link
Contributor Author

Backport is done! #12292

@vbekiaris vbekiaris added this to the 3.10 milestone Feb 9, 2018
@pveentjer pveentjer merged commit 4b0950f into hazelcast:master Feb 13, 2018
@vbekiaris vbekiaris mentioned this pull request Feb 13, 2018
Closed
@mmedenjak mmedenjak added the Source: Community PR or issue was opened by a community user label Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pveentjer pveentjer pveentjer approved these changes

@vbekiaris vbekiaris vbekiaris approved these changes

Assignees
No one assigned
Labels
Source: Community PR or issue was opened by a community user Team: Core Type: Defect
Projects
None yet
Milestone
3.10
Development

Successfully merging this pull request may close these issues.
4 participants
@mumukiller @vbekiaris @pveentjer @mmedenjak