Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move MerkleTreeConfig inside MapConfig #15180

Merged
merged 5 commits into from
Jul 2, 2019
Merged

Move MerkleTreeConfig inside MapConfig #15180

merged 5 commits into from
Jul 2, 2019

Commits on Jul 2, 2019

  1. Move MerkleTreeConfig inside MapConfig 

    Initially, merkle tree configuration was put as a top-level config
because we were anticipating its' usage in cache as well but we were not
able to change CacheConfig because of client backwards compatibility
(see BinaryInterface annotation).
Now with 4.0, we will remove this restriction which means merkle tree
config can be part of both map and cache config (once it's implemented
for cache).
Using it this way will eliminate some of the confusion as up until now
the user had to additionally specify the mapName on the merkle tree
configuration to 'connect' the merkle tree configuration to the map
configuration.
    Matko Medenjak committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    ddc318f View commit details
    Browse the repository at this point in the history

  2. Fix tests

    Matko Medenjak committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    b0304c9 View commit details
    Browse the repository at this point in the history

  3. Checkstyle

    Matko Medenjak committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    22d50f2 View commit details
    Browse the repository at this point in the history

  4. Address review comments

    Matko Medenjak committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    4c4f2ee View commit details
    Browse the repository at this point in the history

  5. Spotbugs

    Matko Medenjak committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    73d5028 View commit details
    Browse the repository at this point in the history