Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#15346] Fix deserialization filtering for Externalizables and Deadlock in Map index #15358

Merged
merged 3 commits into from Jul 24, 2019

Conversation

@kwart
Copy link
Contributor

kwart commented Jul 23, 2019

Fixes #15346 and also leaking record lock in the Records class.

Copy link
Contributor

vbekiaris left a comment

nice job, some minor comments


sendJoinDatagram(new TestDeserialized());
Thread.sleep(500L);
assertTrueEventually(() -> assertTrue("Object was not deserializaed", TestDeserialized.isDeserialized));

This comment has been minimized.

Copy link
@vbekiaris

vbekiaris Jul 23, 2019

Contributor

minor: typo in deserializaed

Hazelcast.newHazelcastInstance(config);

sendJoinDatagram(new TestDeserialized());
Thread.sleep(500L);

This comment has been minimized.

Copy link
@vbekiaris

vbekiaris Jul 23, 2019

Contributor

no need to sleep here since we use assertTrueEventually next

Object object = serializationService.toObject(valueBeforeCas);
Object object = null;
try {
object = serializationService.toObject(valueBeforeCas);

This comment has been minimized.

Copy link
@vbekiaris

vbekiaris Jul 23, 2019

Contributor

good catch!

@kwart

This comment has been minimized.

Copy link
Contributor Author

kwart commented Jul 24, 2019

Thanks for review, @vbekiaris. The findings are fixed in a new commit.

@kwart kwart merged commit f029f9f into hazelcast:master Jul 24, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@kwart kwart deleted the kwart:deserialization-externalizable branch Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.