[#15346] Fix deserialization filtering for Externalizables and Deadlock in Map index #15358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd Deadlock in Map index
vbekiaris
approved these changes
Jul 23, 2019
|
|
||
| sendJoinDatagram(new TestDeserialized()); | ||
| Thread.sleep(500L); | ||
| assertTrueEventually(() -> assertTrue("Object was not deserializaed", TestDeserialized.isDeserialized)); |
There was a problem hiding this comment.
minor: typo in deserializaed
| Hazelcast.newHazelcastInstance(config); | ||
|
|
||
| sendJoinDatagram(new TestDeserialized()); | ||
| Thread.sleep(500L); |
There was a problem hiding this comment.
no need to sleep here since we use assertTrueEventually next
| Object object = serializationService.toObject(valueBeforeCas); | ||
| Object object = null; | ||
| try { | ||
| object = serializationService.toObject(valueBeforeCas); |
|
Thanks for review, @vbekiaris. The findings are fixed in a new commit. |
ahmetmircik
approved these changes
Jul 24, 2019
vbekiaris
approved these changes
Jul 24, 2019
mmedenjak
added
Module: Security
security
|
@kwart , @vbekiaris @mmedenjak : is it possible to pick up a build of the 3.12.2 jar containing this fix? If so, how/where? |
|
@chefhoobajoob Latest 3.12.z build is the 3.12.12.
|
|
@kwart : great! thank you, the visa tag was explicitly mentioned in security scans as the version to update to, so pretty confusing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15346 and also leaking record lock in the
Recordsclass.