Cleanup HazelcastCachingProvider #15890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbekiaris
force-pushed
the
fixes/4.0/cleanup-caching-provider
branch
from
61f5f70
to
888070d
Compare
vbekiaris
force-pushed
the
fixes/4.0/cleanup-caching-provider
branch
from
888070d
to
338385d
Compare
vojtechtoman
approved these changes
Nov 3, 2019
Removes public static factory methods from member- and client-side caching providers. Adds javadoc to HazelcastCachingProvider to clarify caching provider and cache manager creation options, indicate how to start or reuse HazelcastInstances and removes some out-of-date information.
Shared code for get-or-create HazelcastInstance that backs CacheManager has been pulled up to AbstractHazelcastCachingProvider. Server/client- specific pieces have been extracted to smaller methods in the respective implementations.
vbekiaris
force-pushed
the
fixes/4.0/cleanup-caching-provider
branch
from
338385d
to
9e9dc59
Compare
ihsandemir
approved these changes
Nov 5, 2019
|
run-lab-run |
1 similar comment
|
run-lab-run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes public static factory methods from member- and client-side
caching providers. Adds javadoc to HazelcastCachingProvider to clarify
caching provider and cache manager creation options, indicate how to
start or reuse HazelcastInstances and removes out-of-date
information.
Also, shared code between server & client caching providers has been
pulled up to
AbstractHazelcastCachingProvider. The client/server-specificparts are now in smaller methods in their respective implementations.
Fixes #15144
Fixes #11190
EE counterpart: https://github.com/hazelcast/hazelcast-enterprise/pull/3294