Removes user executor #16215
Merged
Removes user executor #16215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbekiaris
force-pushed
the
fixes/4.0/remove-user-executor
branch
from
2f55adb
to
b9e71f9
Compare
|
run-lab-run |
1 similar comment
|
run-lab-run |
sancar
reviewed
Dec 16, 2019
| @@ -170,7 +171,7 @@ public ClientTransactionManagerService getTransactionManager() { | |||
| return transactionManager; | |||
| } | |||
|
|
|||
| public ClientExecutionService getExecutionService() { | |||
| public TaskScheduler getExecutionService() { | |||
There was a problem hiding this comment.
I think we can remove ClientExecutionService interface completely and also change the method name to getTaskScheduler . There seems to be no use left for ClientExecutionService interface anymore.
vbekiaris
force-pushed
the
fixes/4.0/remove-user-executor
branch
from
b9e71f9
to
f1bfe39
Compare
sancar
approved these changes
Dec 16, 2019
User callbacks are now executed by default in the DEFAULT_ASYNC executor. The few remaining usages of user executor have been replaced and user executor along with its configuration is removed.
vbekiaris
force-pushed
the
fixes/4.0/remove-user-executor
branch
from
5682e09
to
4fa5d6c
Compare
kwart
approved these changes
Dec 17, 2019
| @@ -313,7 +313,7 @@ public String toString() { | |||
| } | |||
| })); | |||
| executor.shutdownIncoming(); | |||
|
|
|||
| System.out.println(">>>> >>>>>"); | |||
| @@ -329,6 +329,7 @@ public void run() { | |||
| } | |||
| }); | |||
| executor.shutdownOutgoing(); | |||
| System.out.println("<<<< <<<<"); | |||
|
PR builder failed with known issue #16099 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes user executor and associated config, as discussed here