FlakeIdGenerator advanced configuration #16278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
lukasherman
added a commit
to lukasherman/hazelcast-client-protocol
that referenced
this pull request
Dec 17, 2019
|
run-lab-run |
|
Hi @lukasherman ! Thank you for your contribution. |
viliam-durina
suggested changes
Dec 18, 2019
hazelcast/src/main/java/com/hazelcast/config/FlakeIdGeneratorConfig.java
Outdated
Show resolved
Hide resolved
hazelcast/src/main/java/com/hazelcast/config/FlakeIdGeneratorConfig.java
Outdated
Show resolved
Hide resolved
hazelcast/src/main/java/com/hazelcast/flakeidgen/impl/FlakeIdGeneratorProxy.java
Show resolved
Hide resolved
lukasherman
added a commit
to lukasherman/hazelcast-client-protocol
that referenced
this pull request
Dec 30, 2019
lukasherman
commented
Dec 30, 2019
|
@lukasherman Sorry for inconvenience,there is conflict related to generated files since another pr has changed the protocol, you are gonna need to rebase both pr's and regenerate the codecs. |
Only when more than 8 cpu's are detected a smart client will get 3+3 io threads. This will prevent performance regressions on smaller boxes.
…roperties: - epochStart - bitsTimestamp - bitsSequence - bitsNodeId - allowedFutureMillis Fixes #14150
added sanity checks removed no longer valid out of range check added unit test for custom configuration
removed idOffset and bitsTimestamp fields from configuration regenerated client protocol interfaces
…t-threadcount-for-fast-boxes IO threadcount for smart client only when enough cpu's
|
run-lab-run |
After client has authenticated, we were sending IsFailoverSupportedMessageTask (when newHazelcastFailoverClient is used) to query if members have the support. In this pr, we put this info to Authentication response to avoid second step. This was a different message task for backward compatibility reasons. When client has connected to a member that feature is not available yet, we wanted to get exception. Since there is no old server anymore, a second message task is not needed. related protocol change hazelcast/hazelcast-client-protocol#288 fixes #16336
It could happen that this connection is already closed and onConnectionClose() is called even before the authentication handling logic is executed. In this case, now we have a closed but registered connection in the client connection manager. We do a final check to remove this connection if needed. This check was already here before and removed with 3d897c2 because of wrong reasoning. Fixes #16288
Handle closed client connection after registration
|
@lukasherman sorry, the client protocol changed again. Can you rebase hazelcast/hazelcast-client-protocol#281 and regenerate classes for this PR? |
…roperties: - epochStart - bitsTimestamp - bitsSequence - bitsNodeId - allowedFutureMillis Fixes #14150
added sanity checks removed no longer valid out of range check added unit test for custom configuration
removed idOffset and bitsTimestamp fields from configuration regenerated client protocol interfaces
…hub.com/lukasherman/hazelcast into flakeidgenerator-advanced-configuration
|
run-lab-run |
|
Merged, thank you for the contribution @lukasherman and the reviews everyone! |
mmedenjak
added
Source: Community
mdumandag
pushed a commit
to hazelcast/hazelcast-client-protocol
that referenced
this pull request
Jan 7, 2020
* FlakeIdGeneratorConfig extensions Core PR: hazelcast/hazelcast#16278 * Removed idOffset and bitsTimestamp fields from addFlakeIdGeneratorConfig Core PR: hazelcast/hazelcast#16278 * Add hot restart ops definitions for MC client * Add triggerPartitionAssingment message related to hazelcast/hazelcast#16375 * Encode PagingPredicate into protocol and the query response returns anchor list (#274) * Added the paging predicate to the paging predicate query responses so that the client can update its local anchor entry list. * Updated the Map `valuesWithPagingPredicate` to return only a list of values data instead of entries. * Updating the IMap paging predicate query codecs to serialize the PagingPredicate as a custom type and the responses return the updated anchor list. * Added source field to DistributedObject event. (#284) * Added `internal` field to DistributedObject request so that the ProxyManager internal registration to the distributed object listener can be differentiated from the user listeners. (#285) Co-authored-by: Andrey Pechkurov <37772591+puzpuzpuz@users.noreply.github.com> Co-authored-by: sancar <sancar@hazelcast.com> Co-authored-by: ihsan demir <ihsan@hazelcast.com>
|
Summary of breaking changes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Externalizes currently hardcoded id generator properties.
Rationale:
With the upcoming User Defined Services SPI removal it will be no longer possible to implement custom FlakeIdGenerator implementation. This PR addresses shortcomings of the current implementation.
Fixes #14150