Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a warning about nexus-staging-maven-plugin deploy behaviour #26108

Closed
wants to merge 1 commit into from
Closed

Add a warning about nexus-staging-maven-plugin deploy behaviour #26108

wants to merge 1 commit into from

Conversation

JackPGreen
Copy link
Contributor

nexus-staging-maven-plugin deploys to an additional repository outside of distributionManagement, which is what lead to an accidental public release of 5.3.4.

Documentation added to help catch this in future.

@JackPGreen JackPGreen added Team: Core Source: Internal PR or issue was opened by an employee Module: Maven build labels Nov 30, 2023
@JackPGreen JackPGreen added this to the 5.4.0 milestone Nov 30, 2023
@JackPGreen JackPGreen self-assigned this Nov 30, 2023
kwart
kwart reviewed Dec 4, 2023
View reviewed changes
Copy link
Member

@kwart kwart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I understand it correctly, the nexusUrl parameter of the nexus-staging-maven-plugin is the one controlling the target staging location?
If it is so, please point to it in the comment.

@JackPGreen
Copy link
Contributor Author

Do I understand it correctly, the nexusUrl parameter of the nexus-staging-maven-plugin is the one controlling the target staging location? If it is so, please point to it in the comment.

2e6a914

@JackPGreen JackPGreen enabled auto-merge (squash) December 4, 2023 12:29
@JackPGreen
Copy link
Contributor Author

run-lab-only

auto-merge was automatically disabled December 8, 2023 10:31

Head branch was pushed to by a user without write access

@JackPGreen JackPGreen force-pushed the Add-a-warning-about-`nexus-staging-maven-plugin`-deploy-behaviour branch from d57aa4c to 2ea9e3b Compare December 8, 2023 10:31
@devOpsHazelcast
Copy link
Collaborator

Internal PR hazelcast/hazelcast-mono#120
Internal message only. Nothing to see here, move along

@JackPGreen JackPGreen closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwart kwart Awaiting requested review from kwart

@nishaatr nishaatr Awaiting requested review from nishaatr

Assignees

@JackPGreen JackPGreen

Labels
Module: Maven build Not Release Notes content Source: Internal PR or issue was opened by an employee Team: Core
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@JackPGreen @devOpsHazelcast @kwart @nishaatr