Fix fired events when initialMembersipListener is used on client #7543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When initial membership event added before client is started, it was firing individual ADDED events for current memberlist, along with InitialMembershipEvent. Only latter is preserved, other events are removed. Related tests are added. Membershiplistener related tests in ClientRegressionWithMockNetworkTest are moved to MembershipListenerTest. fixes hazelcast#7430
sancar
pushed a commit
to sancar/hazelcast
that referenced
this pull request
Feb 18, 2016
When initial membership event added before client is started, it was firing individual ADDED events for current memberlist, along with InitialMembershipEvent. Only latter is preserved, other events are removed. Related tests are added. Membershiplistener related tests in ClientRegressionWithMockNetworkTest are moved to MembershipListenerTest. fixes hazelcast#7430 backport of hazelcast#7543
| * related to issue #1181 | ||
| */ | ||
| @Test | ||
| public void testAddInitialMembership_whenListenerAddedViaClientConfig() throws InterruptedException { |
There was a problem hiding this comment.
why is there no assert? What is being tested?
There was a problem hiding this comment.
Before the fix, It was throwing NullPointer exception according to issue mentioned in #1181 . It is testing that it does not throw any exception.
|
👍 |
1 similar comment
|
👍 |
asimarslan
added a commit
that referenced
this pull request
Feb 23, 2016
…master Fix fired events when initialMembersipListener is used on client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initial membership event added before client is started,
it was firing individual ADDED events for current memberlist,
along with InitialMembershipEvent. Only latter is preserved,
other events are removed.
Related tests are added.
Membershiplistener related tests in ClientRegressionWithMockNetworkTest
are moved to MembershipListenerTest.
fixes #7430