Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please do not hard code the api-version in the AzureChatClient #122

Open
whitewum opened this issue Mar 12, 2024 · 0 comments
Open

Please do not hard code the api-version in the AzureChatClient #122

whitewum opened this issue Mar 12, 2024 · 0 comments

Comments

@whitewum
Copy link

    def get_generation_url(self) -> str:
        """Get generation URL."""
        engine = getattr(self, "engine")
        deployment_name = AZURE_DEPLOYMENT_NAME_MAPPING.get(engine, engine)
        return (
            self.host
            + "/openai/deployments/"
            + deployment_name
            + "/chat/completions?api-version=2023-05-15"
        )

The api-version is hard coded as 2023-05-15. Please make it configureable as a parameter or os enviroment.

@whitewum whitewum changed the title Do not hard code the api-version in the AzureChatClient Please do not hard code the api-version in the AzureChatClient Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant