Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think there are some errors in the mt_end_model.py #200

Open
WenxiongLiao opened this issue May 30, 2019 · 1 comment
Open

I think there are some errors in the mt_end_model.py #200

WenxiongLiao opened this issue May 30, 2019 · 1 comment
Assignees

Comments

@WenxiongLiao
Copy link

WenxiongLiao commented May 30, 2019

When I use LSTMModule as the input_modules ,there will be a error: UnboundLocalError: local variable 'output_dim' referenced before assignment
image

so, I check the code of metal.multitask.mt_end_model.py
I found the local variable 'output_dim' really referenced before assignment at line 115.
I changed this line to output_dim=self.config["layer_out_dims"][0] , the input_modules can work.

But I am not sure if I am correct. I hope the author can check the code and it is best to give a tutorial of LSTMModule using as input_modules.

@bhancock8
Copy link
Contributor

Thanks for bringing this to our attention! It looks like you were using the LSTM correctly. This should be fixed by PR #211.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants