Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with naming in Python 3.9 #66

Closed
ekisiel97 opened this issue Jan 7, 2021 · 1 comment
Closed

Problem with naming in Python 3.9 #66

ekisiel97 opened this issue Jan 7, 2021 · 1 comment

Comments

@ekisiel97
Copy link

ekisiel97 commented Jan 7, 2021

Using Python 3.9, the following error will appear

File "/usr/lib/python3.9/threading.py", line 954, in _bootstrap_inner self.run()
File "/home/user/.local/lib/python3.9/site-packages/spotify_ripper/eventloop.py", line 78, in run
while self._runnable and self._ripper.isAlive():
AttributeError: "Ripper" object has no attribute "isAlive"

This is due to the fact that the inheritance of the Thread class from the threading has renamed the attribute isAlive() to is_alive().

This is easily fixed by changing the three files main.py, eventloop.py and ripper.py which each have exactly one instance of the isAlive attribute being referenced. This took me a while to find so hopefully for those who run into this in the future encounter this problem can fix it from this.

@tmaier
Copy link

tmaier commented Mar 26, 2021

Hi, can you provide a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants