Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error on MSVC due to POSIX headers (sys/resource.h, sys/time.h) include in Seb_debug.h #26

Open
quxflux opened this issue May 16, 2020 · 1 comment

Comments

@quxflux
Copy link

quxflux commented May 16, 2020

When compiling a project which includes "Seb.h" using MSVC, compilation will fail due to the missing POSIX headers:

cpp\main/Seb_debug.h(12,10): fatal error : 'sys/resource.h' file not found

I was able to work around this in a fork of the repo by forward declaring the used timeval struct.

A cleaner way would probably to either git rid of the POSIX header dependency and rely solely on functionality from the C++ standard library (e.g. std::chrono) or at least prevent the compiler from hitting the mentioned include when SEB_DEBUG_MODE is not defined.

@hbf
Copy link
Owner

hbf commented May 16, 2020

@TheGrumpyCoda Thanks a lot for reporting this. If you have time to submit a PR, feel free to do so—very happy to take your fix/improvement in, pc course!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants