-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requires boost for regular make #60
Comments
I think it's related to not having a regex impl for gcc <= 4.8: http://stackoverflow.com/questions/12530406/is-gcc-4-8-or-earlier-buggy-about-regular-expressions @rdumusc correct me if I'm wrong and if there's another reason for choosing boost.regex here. |
GCC <= 4.8 isn't C++11 feature-complete anyway. GCC 4.8.1 is the first version which is: https://gcc.gnu.org/projects/cxx-status.html . It might be (IMO) better to put the boost stuff behind the SERVUS_USE_CXX03 ifdef, defining that automatically if the GCC version < 4.8.1. |
correct, when I last checked std::regex support was lacking in most implementations of the standard, but we should use it if in fact possible. |
Yes, implementation of std::regex_match comes with gcc 4.9 only (http://stackoverflow.com/questions/12530406/is-gcc-4-8-or-earlier-buggy-about-regular-expressions) |
As of this commit. Since we're in C++11, why not just use basic_regex?
229a659
The text was updated successfully, but these errors were encountered: