Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requires boost for regular make #60

Closed
jeremybernstein opened this issue Jun 27, 2016 · 4 comments
Closed

requires boost for regular make #60

jeremybernstein opened this issue Jun 27, 2016 · 4 comments
Assignees

Comments

@jeremybernstein
Copy link

As of this commit. Since we're in C++11, why not just use basic_regex?

229a659

@tribal-tec
Copy link
Contributor

I think it's related to not having a regex impl for gcc <= 4.8: http://stackoverflow.com/questions/12530406/is-gcc-4-8-or-earlier-buggy-about-regular-expressions

@rdumusc correct me if I'm wrong and if there's another reason for choosing boost.regex here.

@jeremybernstein
Copy link
Author

jeremybernstein commented Jun 27, 2016

GCC <= 4.8 isn't C++11 feature-complete anyway. GCC 4.8.1 is the first version which is: https://gcc.gnu.org/projects/cxx-status.html . It might be (IMO) better to put the boost stuff behind the SERVUS_USE_CXX03 ifdef, defining that automatically if the GCC version < 4.8.1.

@rdumusc
Copy link

rdumusc commented Jun 27, 2016

correct, when I last checked std::regex support was lacking in most implementations of the standard, but we should use it if in fact possible.
Otherwise, I agree that boost::regex should be an optional dependency. It is only used for printing a compatibility warning for the URI parsing, which I am not sure is even required any longer.

@rdumusc
Copy link

rdumusc commented Jun 27, 2016

Yes, implementation of std::regex_match comes with gcc 4.9 only (http://stackoverflow.com/questions/12530406/is-gcc-4-8-or-earlier-buggy-about-regular-expressions)
Added compiler guards to not include the warning when compiling without boost:
#61

rdumusc pushed a commit that referenced this issue Jun 27, 2016
Fix Servus build without boost after #47 (fix #60)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants