Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design search result list #26

Closed
acka47 opened this issue Sep 20, 2017 · 9 comments
Closed

Design search result list #26

acka47 opened this issue Sep 20, 2017 · 9 comments

Comments

@acka47
Copy link
Contributor

acka47 commented Sep 20, 2017

This probably has #24 (plus the addition of other labels) as prerequisite.

Currently, the search result list shows name, some variant names and the GND ID with a link to the entry at the DNB. With this ticket we should discuss and implement a more useful result list.

Here are some ideas:

  • Neither show the GND ID or a link to the DNB service. It suffices to have this in the detail view
  • For Person, show occupation (professionOrOccupation) and birth/death year.
  • For ConferenceOrEvents, show place (placeOfConferenceOrEvent) and date (dateOfConferenceOrEvent. (May not be necessary as this is also appended in parentheses to the preferred name.)
  • for CorporateBody show placeOfBusiness (more than half of the 1.4 Million corporate bodies have that info).
  • For Workwe definitely need firstAuthor/firstComposer,
  • For PlaceOrGeographicName show geographicAreaCode
  • For SubjectHeading show gndSubjectCategory
@fsteeg
Copy link
Member

fsteeg commented Sep 22, 2017

Neither show the GND ID or a link to the DNB service. It suffices to have this in the detail view

My thought here was that I'd expect it to be a common use case to find a specific GND ID. Getting these right from the result list seems much easier than having to go to the details, in particular when doing that multiple times.

@acka47
Copy link
Contributor Author

acka47 commented Mar 22, 2018

This probably has #24 (plus the addition of other labels) as prerequisite.

We decided to load them on-the-fly for now in the UI.

@acka47 acka47 assigned fsteeg and unassigned acka47 and ChristophEwertowski Mar 22, 2018
@acka47 acka47 added the ready label Mar 22, 2018
@fsteeg fsteeg added working and removed ready labels Apr 6, 2018
fsteeg added a commit that referenced this issue Apr 6, 2018
fsteeg added a commit that referenced this issue Apr 6, 2018
fsteeg added a commit that referenced this issue Apr 6, 2018
@fsteeg
Copy link
Member

fsteeg commented Apr 6, 2018

Deployed to stage: http://stage.lobid.org/gnd/search

@fsteeg fsteeg added review and removed working labels Apr 6, 2018
@fsteeg fsteeg assigned acka47 and ChristophEwertowski and unassigned fsteeg Apr 6, 2018
@fsteeg fsteeg assigned fsteeg and unassigned fsteeg Apr 6, 2018
@acka47
Copy link
Contributor Author

acka47 commented Apr 6, 2018

Generally, I am not sure whether we should show the GND-Sachgruppen in the result list. Some more first thoughts:

We definitely shouldn't show the field names "Ländercode", "GND-Sachgruppe", "Beruf oder Beschäftigung". Also, years are enough for the birth and death dates.

Example http://stage.lobid.org/gnd/search?q=105042919: Historiker, 1919-2011

For Körperschaften and Events the combination "Veranstaltungsort/Sitz, Ländercode" seems to make sense.

Example http://stage.lobid.org/gnd/search?q=%227640-5%22: Berlin (West), Deutschland

Example http://stage.lobid.org/gnd/search?q=%227648-X%22+AND+stiftsarchiv: Sankt Gallen, Sankt Gallen <Kanton>

@ChristophEwertowski
Copy link
Contributor

I concur with @acka47 for the field names and showing only birth and death years even if the date and month are known.
But I don't think that we need "Veranstaltungsort/Sitz" as they can be read in the preferredName (see http://stage.lobid.org/gnd/7735-5). "Ländercode" would be good, though.

@fsteeg fsteeg assigned fsteeg and unassigned acka47 and ChristophEwertowski Apr 9, 2018
@fsteeg
Copy link
Member

fsteeg commented Apr 9, 2018

Deployed to stage: http://stage.lobid.org/gnd/search?q=%222047974-8%22

@fsteeg fsteeg assigned acka47 and ChristophEwertowski and unassigned fsteeg Apr 9, 2018
@ChristophEwertowski
Copy link
Contributor

+1

@ChristophEwertowski ChristophEwertowski removed their assignment Apr 9, 2018
@fsteeg fsteeg added working and removed review labels Apr 12, 2018
@fsteeg fsteeg assigned fsteeg and unassigned acka47 Apr 12, 2018
fsteeg added a commit that referenced this issue Apr 12, 2018
@fsteeg
Copy link
Member

fsteeg commented Apr 12, 2018

Discussed offline: types should get a separate column, prefer subtypes.

Deployed to test: https://test.lobid.org/gnd/search?q=saturn

@fsteeg fsteeg assigned acka47 and unassigned fsteeg Apr 12, 2018
@fsteeg fsteeg added review and removed working labels Apr 12, 2018
@acka47
Copy link
Contributor Author

acka47 commented Apr 12, 2018

+1

@acka47 acka47 assigned fsteeg and unassigned acka47 Apr 12, 2018
@fsteeg fsteeg removed their assignment Apr 12, 2018
@dr0i dr0i added deploy and removed review labels Apr 12, 2018
@fsteeg fsteeg closed this as completed in 641524b Apr 12, 2018
@fsteeg fsteeg removed the deploy label Apr 12, 2018
fsteeg added a commit that referenced this issue Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants