Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nwb tutorial bug #56

Merged
merged 3 commits into from
Jan 3, 2023
Merged

Fix nwb tutorial bug #56

merged 3 commits into from
Jan 3, 2023

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Dec 24, 2022

Fix #55
Fix #59

@oruebel oruebel added category: bug errors in the code or code behavior topic: docs Issues related to documentation labels Dec 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2022

Codecov Report

Base: 82.15% // Head: 82.15% // No change to project coverage 👍

Coverage data is based on head (1fe71a8) compared to base (6841196).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #56   +/-   ##
=======================================
  Coverage   82.15%   82.15%           
=======================================
  Files           9        9           
  Lines        2365     2365           
=======================================
  Hits         1943     1943           
  Misses        422      422           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bendichter
Copy link
Contributor

@oruebel any idea what is causing problems with py3.7?

@oruebel
Copy link
Contributor Author

oruebel commented Dec 24, 2022

@oruebel any idea what is causing problems with py3.7?

@mavaylon1 and @rly are working on the Python 3.7 pipelines in #53

@mavaylon1
Copy link
Contributor

Is this still ready for a review? @oruebel

@oruebel
Copy link
Contributor Author

oruebel commented Jan 3, 2023

@mavaylon1 this PR is ready for review

@oruebel
Copy link
Contributor Author

oruebel commented Jan 3, 2023

I can't tell whether the failing runs are due to problems here or because of changes pending in #53 I'll merge these changes and then we can debug in #53

@mavaylon1
Copy link
Contributor

@oruebel are you able to merge without passing the required tests?

@oruebel oruebel merged commit e3d063a into dev Jan 3, 2023
@oruebel oruebel deleted the fix/nwb_tutorial_bug branch January 3, 2023 20:13
@oruebel
Copy link
Contributor Author

oruebel commented Jan 3, 2023

I temporarily changed the settings to allow bypassing of checks for admins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior topic: docs Issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyNWB warnings in plot_convert_nwb_hdf5.py Dimension warning for ElectricalSeries in NWBZarrIO Tutorial
4 participants