-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add support for using select user-defined zarr stores #62
Conversation
I will split this into two PRs. Allowing TempStore, DirectoryStore, and NestedDirectoryStore is much simpler as those all derive from DirectoryStore. Adding the more file- and database-oriented stores, e.g., zip or SQL, will be more work with regard to support for links and references (especially during export and when linking across Zarr files with different backend stores). I created issue #65 to explore adding more stores. |
Codecov ReportBase: 80.57% // Head: 82.03% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #62 +/- ##
==========================================
+ Coverage 80.57% 82.03% +1.45%
==========================================
Files 10 11 +1
Lines 2435 2644 +209
==========================================
+ Hits 1962 2169 +207
- Misses 473 475 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…edicated test classes
@rly @mavaylon1 this PR is ready for review |
Note, the external link check is failing here, because it includes a link to a file that is being added to the main repo by this PR. I.e., once this PR is merged that link should be correct. |
@rly thanks for the suggestions. I have now resolved all the items and this PR is now ready for you to take another look at for review. Specifically I:
|
Looks good to me. Thanks for the changes! |
Motivation
Currently ZarrIO only supports Zarr's the default DirectoryStore. It would be nice to add support for additional data stores.
DirectoryStore
,NestedDirectoryStore
andTempStore
for read and write inZarrIO
test_zarr_io.py
to support specification of backend stores and add unit tests based ontest_zarr_io.py
for the new stores.test_io_convert.py
for the new storesZarrIO