Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Expandable datasets (HDF5) #1153

Open
mavaylon1 opened this issue Jul 18, 2024 · 2 comments · Fixed by #1158
Open

[Feature]: Expandable datasets (HDF5) #1153

mavaylon1 opened this issue Jul 18, 2024 · 2 comments · Fixed by #1158
Assignees

Comments

@mavaylon1
Copy link
Contributor

What would you like to see added to HDMF?

We previously implemented VectorData expanable by default, but had to pull it from production. https://github.com/hdmf-dev/hdmf/pull/1093/files#diff-508770382f78baf6681e42837b28809b522de14e7fa401c32daffa28538396c4

We are doing round 2:

  1. Implement the same setup as the ticket above; however, pull shape information from the schema. There are examples where you have multiple shape options in the schema; we need to ensure that the shape option used matches the shape of the data. If there is no shape, determine via dim of the data.
  2. We want to support dataset of references also being expandable. Look to append ticket: https://github.com/hdmf-dev/hdmf/pull/1135/files#diff-2f0fd76dfef06a7d2164a052a72a224ea80cafbfde6dd753aca67d2b1eb02145

What solution would you like?

above

Do you have any interest in helping implement the feature?

Yes.

@mavaylon1 mavaylon1 self-assigned this Jul 18, 2024
@mavaylon1
Copy link
Contributor Author

Related #1064

@mavaylon1
Copy link
Contributor Author

We need to add a field within the builders called "permissible_shape" to pass the spec shape info into the builder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant