Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

u128 support #80

Open
marshallpierce opened this issue May 14, 2018 · 2 comments
Open

u128 support #80

marshallpierce opened this issue May 14, 2018 · 2 comments

Comments

@marshallpierce
Copy link
Collaborator

Should we move things like the total number of counts to u128? That may have a detrimental affect on performance, especially on lesser hardware; I haven't benchmarked it yet to see.

@jonhoo
Copy link
Collaborator

jonhoo commented May 14, 2018

Hmm.. Maybe as a feature? Do we expect u64 to ever not be enough for counts though?

@marshallpierce
Copy link
Collaborator Author

Probably not... u64 is 584 years of 1 billion increments per second. Just figured I'd throw this out to see if anyone had a plausible use case. I'll ask in gitter too.

There are also serialization concerns -- Java already can't represent u64 (only i64) and u128 would be even more hopeless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants