Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0.0 release notes missing information on breaking changes #31

Closed
amclin opened this issue May 26, 2020 · 4 comments
Closed

5.0.0 release notes missing information on breaking changes #31

amclin opened this issue May 26, 2020 · 4 comments
Labels

Comments

@amclin
Copy link

amclin commented May 26, 2020

Major releases indicate breaking changes, yet the changelog doesn't explain what breaks in v5.0.0

This makes it very difficult to assess whether my projects can safely update to 5.0.0

@headcr4sh
Copy link
Owner

You are right. The new major version was a mistake.

I was looking through the changes and created a new versioj, because the method signature of the maven invocation changed. I didn't check carefully enough, otherwise it would have been obvious immediately that the new optional parameter didn't introduce a breaking change.

My bad...
... a note in the release notes would be nice, I suppose. I'll keep this ticket open until the CHANGELOG.md has been updated.

@headcr4sh
Copy link
Owner

I just figured out that no CHANGELOG.md is present in this project. Very curious... I have updated the GitHub releases page and added information concerning the non-existing breaking changes in v5.0.0.

Closing this issue.

@amclin
Copy link
Author

amclin commented Jun 1, 2020

@headcr4sh thanks for getting back on this - but on closer investigation of the changes you do have a breaking change - an explicit bump of the minimum NodeJS requirement from v4.0 to v12.0 in the engines field of package.json

@headcr4sh
Copy link
Owner

Uh. Yes.. you are right. That change though, was not intended and necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants