Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text | Can't control Span containing the children from API #384

Open
aVileBroker opened this issue Apr 15, 2022 · 0 comments
Open

Text | Can't control Span containing the children from API #384

aVileBroker opened this issue Apr 15, 2022 · 0 comments
Labels
0.5 Story Points issue size: .5 enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@aVileBroker
Copy link
Contributor

Line 98 of Text.tsx:

    <Skeleton color={color} StyledContainer={SkeletonContainer} isLoading={isLoading}>
      <Span>{children}</Span>
    </Skeleton>

I would expect to be able to style, change props, and get ref of this element.

AC:

  • StyledText
  • textProps
  • textRef

The naming is up to the developer - I think having containerProps and textProps on a component called "Text" is confusing..

@aVileBroker aVileBroker added enhancement New feature or request 0.5 Story Points issue size: .5 labels Apr 15, 2022
@aVileBroker aVileBroker added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 15, 2022
@aVileBroker aVileBroker reopened this Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.5 Story Points issue size: .5 enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Done
Development

No branches or pull requests

1 participant