-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release healpy 1.17.1 #914
Comments
Since this release does not seem to address an urgent need, can you wait a couple of weeks before doing it, so I have a chance to put together a Healpix release ? |
Actually, the dependency and wheel size issue is urgent for us. See nasa-gcn/gcn.nasa.gov#1974. |
I downloaded the artifact wheels produced in #905 and tested install in a virtualenv. Those wheels have a bundled
but I can open a question on that repo. Maybe it is not important- I think libgomp would get found regardless on linux builds and on macos the package would simply not use OpenMP. |
@tskisner, the macOS Conda packages definitely are supposed to link against OpenMP. But yes, that would be an issue with the feedstock. |
@zonca, would you be willing to do an rc or pre-release ahead of the healpix-cxx update? |
There are several improvements in the upcoming Healpy release that will decrease binary installation size, but the next Healpy release may still be a few weeks away (see healpy/healpy#914 (comment)). Meanwhile, I have used [dumb-pypi](https://pypi.org/project/dumb-pypi/) to create a third-party PyPI index with pre-release build of healpy at https://nasa-gcn.github.io/healpy-prerelease-pypi-index/. Install healpy from there for now in order to fix our deployments.
There are several improvements in the upcoming Healpy release that will decrease binary installation size, but the next Healpy release may still be a few weeks away (see healpy/healpy#914 (comment)). Meanwhile, I have used [dumb-pypi](https://pypi.org/project/dumb-pypi/) to create a third-party PyPI index with pre-release build of healpy at https://nasa-gcn.github.io/healpy-prerelease-pypi-index/. Install healpy from there for now in order to fix our deployments.
There are several improvements in the upcoming Healpy release that will decrease binary installation size, but the next Healpy release may still be a few weeks away (see healpy/healpy#914 (comment)). Meanwhile, I have used [dumb-pypi](https://pypi.org/project/dumb-pypi/) to create a third-party PyPI index with pre-release build of healpy at https://nasa-gcn.github.io/healpy-prerelease-pypi-index/. Install healpy from there for now in order to fix our deployments.
There are several improvements in the upcoming Healpy release that will decrease binary installation size, but the next Healpy release may still be a few weeks away (see healpy/healpy#914 (comment)). Meanwhile, I have used [dumb-pypi](https://pypi.org/project/dumb-pypi/) to create a third-party PyPI index with pre-release build of healpy at https://nasa-gcn.github.io/healpy-prerelease-pypi-index/. Install healpy from there for now in order to fix our deployments.
There are several improvements in the upcoming Healpy release that will decrease binary installation size, but the next Healpy release may still be a few weeks away (see healpy/healpy#914 (comment)). Meanwhile, I have used [dumb-pypi](https://pypi.org/project/dumb-pypi/) to create a third-party PyPI index with pre-release build of healpy at https://nasa-gcn.github.io/healpy-prerelease-pypi-index/. Install healpy from there for now in order to fix our deployments.
We should include #933 in the next release because it is needed for ABI compatibility with Numpy 1.x and 2.x. |
Not that I can think of. Note that we'll need a release of healpix-cxx as well. |
FIne with me, I just hope I get the shared library version right this time! @hivon, do we make a full release, or should I do an intermediate C++-only tarball? |
I do plan to make a full release, but it may take some time to wrap it up and integrate the new healpy in it. |
I think we can probably have the best of both worlds. If I know the version number (I guess 3.83?) and you don't require additional changes to the C++ part, I can just try to produce the "official" C++ only tarball in advance. |
Yes, it would be 3.83. |
@lpsinger, can you check the attached file? |
I am having some problems with updating the Debian package. Please hold, @zonca. I'll elaborate shortly. |
See #942. |
A new release would be very useful for us as well---specifically we would need the fix from #944 available on PyPI. Otherwise we have to max version pin matplotlib in half a dozen repos. |
@lpsinger would it be worth it to release with broken MacOS builds? #942 (comment) Then release 1.17.1 when this is fixed in |
The MacPorts builds are not broken. The problem is that cfitsio's build system is broken for shared libraries. MacPorts has a patch that fixes it. HEASARC/cfitsio#18 is currently blocking #942. You could certainly do a release now; the only defect that I know if is that it will be statically linked against cfitsio and therefore be a much larger distribution than it ought to be. I say go for it. I think that the cfitsio build system rewrite is going to take a while. |
Release:
|
Remember that to trigger an upload to PyPI, you need to do a GitHub release in addition to making a tag. |
Wheels are there: https://pypi.org/project/healpy/#files |
@hivon 1.17.1 released. Just waiting for https://github.com/conda-forge/healpy-feedstock bot to make the update on Conda-forge as well |
According to the conda bot status, the version update is failing with the following error message:
I have no idea what any of that means. @duncanmmacleod? Meanwhile, I can do the update manually. |
conda package not available yet, see conda-forge/healpy-feedstock#67 |
@lpsinger what if we leave 1.17.1 without a conda package and ship it again in the next release? |
We are shipping the source code for libsharp. The problem is that we are building it as a shared library which is not being incorporated into the conda package. As a short term workaround, I can update the conda packaging to build libsharp as a shared library and install it. I'll work on that over the coming few days. For the slightly longer term ... it seems that the version of libsharp that we are bundling with healpix-cxx is unmaintained, and incompatible with either of the other two standalone flavors of libsharp (https://github.com/Libsharp/libsharp and https://gitlab.mpcdf.mpg.de/mtr/libsharp). Given that, I suppose that I would suggest really vendoring libsharp directly into the healpix-cxx source so that it is no longer even a separate package. In the much longer term, I think that you, @mreineck, and I should buckle down and talk about alternatives to healpix-cxx like ducc0 etc. It's still really a shame that the HEALPix maintainers are set on keeping development on Subversion on SourceForge and having the very customized and brittle monorepo layout. That's not the underlying problem here, but it's an additional challenge. |
More than happy to work on that, see #717 :-) I'm also fine with doing the migration in steps, e.g. switch the SHTs first. From |
I finished updating the Conda packaging. Can we close this issue now? |
Thanks! |
We plan to make a new healpy release, the most important change is #910 which makes matplotlib and scipy optional dependencies.
Given this change in requirements, I think it is appropriate to name the new release
1.17.0
.I also plan to update the C++ package, even if there should not be any significant changes there.
@mreineck @hivon any feedback?
The text was updated successfully, but these errors were encountered: