Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build against Numpy>=2.0.0rc1 #933

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

lpsinger
Copy link
Member

Numpy 2.0.0 is coming out soon. In order to support both Numpy 1.x and 2.x, we must build against Numpy 2.x.

The official guidance from Numpy is that we should be targeting numpy 2.0.0rc1 as a build dependency now.

Numpy 2.0.0 is coming out soon. In order to support both Numpy
1.x and 2.x, we must build against Numpy 2.x.

The [official guidance from Numpy](https://numpy.org/devdocs/dev/depending_on_numpy.html#numpy-2-abi-handling)
is that we should be targeting numpy 2.0.0rc1 as a build dependency
now.
@lpsinger
Copy link
Member Author

@zonca, would you please review this?

Copy link
Member

@zonca zonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good, it is just a depencency at build time

@zonca zonca merged commit 808a505 into healpy:main Apr 11, 2024
6 checks passed
@lpsinger lpsinger deleted the build-against-numpy-2.0.0 branch April 12, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants