A new option synonyms.ignoreQueryOperators #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, the problem is in the COMPLEX_QUERY_OPERATORS_PATTERN. If I escape the minus (e-commerce) it works properly, but if I place the query in quotes ("e-commerce") the minus is treated as NOT, though it should not and the synonyms are not added. My option just ignores this pattern and doesn't break my queries. |
nolanlawson
added a commit
that referenced
this pull request
Oct 12, 2013
A new option synonyms.ignoreQueryOperators
|
Seems like a reasonable feature, although really I should just be smarter about detecting when the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't use query operators, so no synonyms are added to my query "e-commerce". I remove OR, AND and NOT from my queries before processing through synonym_edismax, so I don't need special treating of the query operators. I have fixed this by adding a new option.